scons dist now signs the synthDriverHost32 runtime executable if it exists.#19749
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the scons dist build so the 32-bit nvda_synthDriverHost.exe runtime executable is code-signed when present, addressing an unsigned binary introduced previously.
Changes:
- Add
nvda_synthDriverHost.exe(x86 runtime) to the list of executables signed duringdist. - Adjust lambda capture to bind the per-iteration file path by value.
- Skip signing for the synthDriverHost runtime if the file doesn’t exist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
@michaelDCurran looking at nvda_snapshot_try-signSynthDriverHost32-54970,1c5d78cd, it looks like the synth driver host is now being signed. It doesn't look like we're signing |
Member
Author
|
We don't tend to sign 3rd party dlls. So that is expected.
|
SaschaCowley
approved these changes
Mar 9, 2026
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
Looks good, pending finalization of testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue:
The 32 bit synthDriverhost runtime executable introduced in PR #19432 is not signed.
Description of user facing changes:
Description of developer facing changes:
Description of development approach:
When building the main dist target with scons, also sign nvda_synthDriverHost.exe if it exists.
This is an improvement over the previous try in pr #19683, where now the path is passed into the lambda by value so that it does not change in the for loop after being captured.
Testing strategy:
*Confirmed that nvda_synthDriverHost.exe was signed.
Known issues with pull request:
None known.
Code Review Checklist: