Fix magnifier tracking vertical lists#19733
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts NVDA magnifier focus-tracking behavior so that during table cell navigation (e.g., Ctrl+Alt+Arrow), the magnifier follows the active cell (navigator/review position) rather than the focused row.
Changes:
- Inverts focus-tracking priority in
FocusManager.getCurrentFocusCoordinates()to prefer navigator changes over system focus changes. - Updates/extends unit tests to cover the “both system focus and navigator changed” scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
source/_magnifier/utils/focusManager.py |
Reorders focus coordinate selection so navigator/review changes take precedence over system focus changes. |
tests/unit/test_magnifier/test_focusManager.py |
Adds a test case validating navigator precedence when both navigator and system focus change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@seanbudd for clarity, I think this fix is only about list views, isn't it? (no need to mention tables in the PR title) |
Member
|
The PR description seems to refer to tables, can that be updated if thats not accurate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19635
Summary of the issue:
When using
Ctrl+Alt+Arrowto navigate vertical list, both the system focus (row) and the navigator object (cell) change simultaneously.In
getCurrentFocusCoordinates(), system focus had priority 3 and navigator had priority 4.As a result, the magnifier always followed the row instead of the active cell.
Description of user facing changes:
Ctrl+Alt+Arrow).Description of developer facing changes:
focusManager.py
Inverted priorities 3 and 4 in
getCurrentFocusCoordinates():Description of development approach:
The fix is limited to priority inversion to align behavior with expected table navigation semantics.
This ensures:
Testing strategy:
Known issues with pull request:
Code Review Checklist: