Use translated strings for driver settings in 32 bit sapi synthDrivers#19562
Merged
Conversation
…and set synthDriverHost's language accordingly, so that any exposed strings, such as driver settings for the synth settings ring, are correctly translated.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a translation issue in the 32-bit SAPI synth drivers where driver setting names (like "rate" and "pitch") were not being translated into the user's configured NVDA language. The fix properly initializes the language handler in the synthDriverHost runtime using the same approach as NVDA core.
Changes:
- Replaces the
getLanguagemethod monkey-patch with proper language initialization vialanguageHandler.setLanguage() - Adds a
getAppArgmethod to the NVDAService to retrieve commandline argument values - Synchronizes the language configuration key from NVDA to the synthDriverHost's local config
- Initializes the language using the same logic as NVDA core (command line override takes precedence over config)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/_bridge/clients/synthDriverHost32/launcher.py | Adds getAppArg service method to expose NVDA commandline arguments to the runtime; removes deprecated getLanguage method |
| source/_bridge/runtimes/synthDriverHost/globalVars.py | Adds language attribute initialization to appArgs |
| source/_bridge/runtimes/synthDriverHost/synthDriverHost.py | Adds "language" to synchronized config values and properly initializes languageHandler using the same logic as NVDA core |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SaschaCowley
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #19557
Summary of the issue:
When using 32 bit sapi synthDrivers introduced with pr #19432, particular strings, such as the display name of driver settings, when moving through the synth settings ring, are not translated into the current NVDA language.
Description of user facing changes:
The translations are now used, if available.
Description of developer facing changes:
Description of development approach:
Testing strategy:
--lang de.Known issues with pull request:
None known.
Code Review Checklist: