remove 32bit OS handling for com registration fixing tool #19523
remove 32bit OS handling for com registration fixing tool #19523SaschaCowley merged 1 commit intobetafrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the COM Registration Fixing Tool to align with NVDA’s 64‑bit-only support and to better handle ARM64 systems, as well as documenting the change in the user changelog.
Changes:
- Simplified COM registration and registry patch helpers to assume NVDA is 64‑bit, removing legacy 32‑bit NVDA handling.
- Introduced ARM64-specific helper functions and wired them into
fixCOMRegistrationsfor both registry patches and COM proxy DLLs. - Documented the COM Registration Fixing Tool behavior change in
user_docs/en/changes.mdand fixed a minor formatting issue in the developer changes section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
source/COMRegistrationFixes/__init__.py |
Refactors COM registration/registry patch logic for a 64‑bit-only NVDA and adds ARM64-specific helpers, used by the COM Registration Fixing Tool and installer. |
user_docs/en/changes.md |
Notes the COM Registration Fixing Tool fix for ARM software and corrects a spacing issue in the developer changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I think all libraries on Arm64 are ARM64X libraries, therefore they bundle both ARM64EC and ARM64 native code. Therefore I indeed think that ARM64 registry patches can be handled like normal X64. I'm not exactly sure about the libraries though. Strictly spoken, I think you might be able to run regsvr32.exe in both ARM64 native and ARM64EC mode. Still, what actually happens is that registry patches are applied under the hoot, and they are also in the same registry location. |
|
Yep - I think we would've run into serious problems with running NVDA on ARM devices if this wasn't already working. I think we can close this PR (or just keep the removal of 32bit handling) and close the original issue as already fixed by the 64bit migration |
74e7f3a to
5c35367
Compare
Link to issue number:
Closes #16200
Summary of the issue:
NVDA would not update com registrations for ARM
Description of user facing changes:
Unknown. after running the com registration fixing tool or the installer, bugs may be fixed when interacting with ARM software
Description of developer facing changes:
None
Description of development approach:
Testing strategy:
Tested running the COM reg tool on an ARM device, ensure it succeeded
Known issues with pull request:
None
Code Review Checklist: