Skip to content

Move Toggle Screen Curtain command to Misc category#19452

Merged
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:remSCCategory
Jan 19, 2026
Merged

Move Toggle Screen Curtain command to Misc category#19452
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:remSCCategory

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of #19177.

Summary of the issue:

Since #19177, Screen curtain settings have been moved from Vision to "Privacy and Security" settings panel in the settings dialog. Though, in the input gestures dialog, its toggle command is still located in the Vision category. This is not consistent.

Description of user facing changes:

In the input gestures dialog, the screen curtain toggle command is now located in the Misc category rather than in the Vision category.

Description of developer facing changes:

N/A

Description of development approach:

Removed the category of the script. A script with no category lands in the Misc category.

Testing strategy:

Manual test of:

  • look at input gesture dialog content
  • input help for screen curtain
  • tested that screen curtain still works.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review January 16, 2026 10:44
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner January 16, 2026 10:44
@CyrilleB79 CyrilleB79 requested a review from seanbudd January 16, 2026 10:44

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 0791101 into nvaccess:beta Jan 19, 2026
39 checks passed
@seanbudd seanbudd added this to the 2026.1 milestone Jan 19, 2026
@github-actions github-actions Bot modified the milestones: 2026.1, 2026.2 Jan 19, 2026
@seanbudd seanbudd modified the milestones: 2026.2, 2026.1 Jan 19, 2026
@CyrilleB79 CyrilleB79 deleted the remSCCategory branch January 19, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants