Move mathCATDir to ReadPaths#19370
Merged
Merged
Conversation
seanbudd
approved these changes
Dec 11, 2025
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix @SaschaCowley
codeofdusk
reviewed
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup #18323
Summary of the issue:
mathCATDiris a property ofNVDAState.WritePaths, even though it is not writable by non-elevated installed copies, and it doesn't seem like we even want to write to it.Description of user facing changes:
None
Description of developer facing changes:
mathCATDiris now a property ofNVDAState.ReadDirs.Description of development approach:
Moved
mathCATDirtoNVDAState._ReadDirs.Searched for usages of
mathCATDirinsource/and updated them.Testing strategy:
Ran from source and interacted with MathML in Firefox.
Known issues with pull request:
None
Code Review Checklist: