Skip to content

Fix starting NVDA with --no-logging flag#19350

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:noLogging
Dec 9, 2025
Merged

Fix starting NVDA with --no-logging flag#19350
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:noLogging

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #19333

Fix-up of #19175.

Summary of the issue:

NVDA was crashing at startup when using --no-logging command line flag.

Description of user facing changes:

NVDA can start again when using the --nologging flag.

Description of developer facing changes:

N/A

Description of development approach:

When loading the crash list file, also test if its path is None since this is the case when using --no-logging flag.

Testing strategy:

Manual tests: Started NVDA with --no-logging, with -l 100 or normally.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner December 8, 2025 13:01
@CyrilleB79 CyrilleB79 requested a review from seanbudd December 8, 2025 13:01
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Cc @derekriemer

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 3f42949 into nvaccess:master Dec 9, 2025
41 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Dec 9, 2025
@CyrilleB79 CyrilleB79 deleted the noLogging branch December 9, 2025 11:45
@derekriemer

Copy link
Copy Markdown
Collaborator

oh boy.

I'm so sorry for not bisecting that before someone else found it. @CyrilleB79 , thanks for detecting that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--no-logging option does not work anymore

3 participants