Fix starting NVDA with --no-logging flag#19350
Merged
Merged
Conversation
Contributor
Author
|
Cc @derekriemer |
Collaborator
|
oh boy. I'm so sorry for not bisecting that before someone else found it. @CyrilleB79 , thanks for detecting that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #19333
Fix-up of #19175.
Summary of the issue:
NVDA was crashing at startup when using --no-logging command line flag.
Description of user facing changes:
NVDA can start again when using the
--nologgingflag.Description of developer facing changes:
N/A
Description of development approach:
When loading the crash list file, also test if its path is
Nonesince this is the case when using--no-loggingflag.Testing strategy:
Manual tests: Started NVDA with
--no-logging, with-l 100or normally.Known issues with pull request:
None
Code Review Checklist: