Skip to content

Don't play spelling error reporting sounds when typing if speech mode is on-demand or off#19348

Merged
SaschaCowley merged 3 commits into
nvaccess:betafrom
CyrilleB79:noErrSound
Dec 11, 2025
Merged

Don't play spelling error reporting sounds when typing if speech mode is on-demand or off#19348
SaschaCowley merged 3 commits into
nvaccess:betafrom
CyrilleB79:noErrSound

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #19323

Summary of the issue:

Sounds reporting errors while typing were emitted even when speech mode was off or on-demand.

Description of user facing changes:

Spelling error sounds while typing are no longer emitted when speech mode are on-demand or off.

Description of developer facing changes:

N/A

Description of development approach:

Check the config to play the error wave file only only if we ar not in off or on-demand mode, i.e. only if we ar in "talk" or "beeps" mode.

Testing strategy:

Manual test in the 4 speech modes.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner December 8, 2025 09:54
@CyrilleB79 CyrilleB79 requested a review from seanbudd December 8, 2025 09:54
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 9, 2025
@seanbudd

seanbudd commented Dec 9, 2025

Copy link
Copy Markdown
Member

@SaschaCowley - okay with this re-targeting to beta? it's a bug fix

@SaschaCowley

SaschaCowley commented Dec 9, 2025

Copy link
Copy Markdown
Member

Yep, @CyrilleB79 could you please re-target this at beta?

@SaschaCowley SaschaCowley marked this pull request as draft December 9, 2025 06:52
@SaschaCowley SaschaCowley added this to the 2026.1 milestone Dec 9, 2025
@CyrilleB79 CyrilleB79 changed the base branch from master to beta December 9, 2025 07:10
@CyrilleB79 CyrilleB79 marked this pull request as ready for review December 9, 2025 07:12
@CyrilleB79

CyrilleB79 commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Yep, @CyrilleB79 could you please re-target this at beta?

Done

SaschaCowley
SaschaCowley reviewed Dec 10, 2025
View reviewed changes
Comment thread user_docs/en/changes.md Outdated
@SaschaCowley SaschaCowley changed the title Spelling error reporting sounds while typing are no longer being emitted when speech mode is on-demand or off Don't play spelling error reporting sounds when typing if speech mode is on-demand or off Dec 10, 2025
@SaschaCowley SaschaCowley enabled auto-merge (squash) December 10, 2025 00:59
@CyrilleB79

CyrilleB79 commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

@SaschaCowley can you re-run the tests?

Automerge does not work because system tests are failed, likely for a reason unrelated to this PR.
As already written to Sean, system tests seem to fail much more often recently, please keep an eye on it.

@SaschaCowley

SaschaCowley commented Dec 10, 2025

Copy link
Copy Markdown
Member

@CyrilleB79 yup, will do. I have also noticed system tests being much flakier over the last few days and am definitely keeping an eye on it

@SaschaCowley SaschaCowley merged commit 00a42a4 into nvaccess:beta Dec 11, 2025
255 of 270 checks passed
@CyrilleB79 CyrilleB79 deleted the noErrSound branch December 11, 2025 12:02
@CyrilleB79 CyrilleB79 mentioned this pull request Apr 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

@seanbudd seanbudd Awaiting requested review from seanbudd seanbudd is a code owner automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2026.1

Development

Successfully merging this pull request may close these issues.

Do not emit spelling error reporting when speech is on-demand or off

3 participants

@CyrilleB79 @seanbudd @SaschaCowley