Skip to content

Update to liblouis 3.36#19316

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:louis336
Dec 3, 2025
Merged

Update to liblouis 3.36#19316
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:louis336

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

Link to issue number:

Closes #19315

Summary of the issue:

Liblouis 3.36.0 was released.

Description of user facing changes:

Added new tables, Macedonian Grade 1 and English Grade 3

Description of developer facing changes:

  1. Added a workaround to our bundled config.h for Liblouis doesn't build with clang on Windows liblouis/liblouis#1889
  2. Python bindings have been updated, so testing should be slightly more careful with regard to that.

Description of development approach:

Updated submodule, added tables.

Testing strategy:

Run from source

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner December 2, 2025 11:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bundled liblouis braille translator library from version 3.35.0 to 3.36.0, adding support for new braille tables and incorporating improvements to existing ones.

Key Changes

  • Updated liblouis submodule to version 3.36.0
  • Added two new braille tables: Macedonian Grade 1 and English Grade 3
  • Added a workaround in config.h for a liblouis build issue

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
user_docs/en/changes.md Updated changelog to reflect the new version and added braille tables
source/brailleTables/__tables.py Registered the new Macedonian Grade 1 and English Grade 3 braille tables
projectDocs/dev/createDevEnvironment.md Updated developer documentation to reference liblouis 3.36.0
nvdaHelper/liblouis/config.h Added stdbool.h include to resolve compilation issues in liblouis 3.36.0
include/liblouis Updated submodule commit reference to version 3.36.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread source/brailleTables/__tables.py Outdated
@seanbudd seanbudd merged commit b8ba741 into nvaccess:master Dec 3, 2025
41 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: update liblouis to the latest 3.36.0 release

3 participants