Move settings to Privacy and Security category#19296
Merged
Merged
Conversation
michaelDCurran
approved these changes
Nov 30, 2025
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
Looks good. But re concern around confusion with groupings: I think I'd suggest at very least placing log level and usage stats controls into a 'General' grouping, and or perhaps moving them to the start of the tab order, though changing the order alone would not stop the confusion when shift+tabbing.
Member
Author
|
@michaelDCurran I've put them in a "General" grouping, but haven't changed the order. I thought that the Screen Curtain settings are more likely to be frequently used, so they make sense to come first in the tab order |
seanbudd
reviewed
Nov 30, 2025
CyrilleB79
reviewed
Dec 1, 2025
seanbudd
approved these changes
Dec 2, 2025
CyrilleB79
approved these changes
Dec 2, 2025
Qchristensen
approved these changes
Dec 2, 2025
Qchristensen
left a comment
Member
There was a problem hiding this comment.
All reads well, hopefully will make it easier for people to find these settings all in one place!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Resolves #16272
Summary of the issue:
NVDA has several settings that have a direct impact on users' privacy and security, but they are scattered throughout its settings dialog.
Description of user facing changes:
Some of these settings have now been moved to the Privacy and Security category.
Description of developer facing changes:
A few items have been removed from the public API.
Description of development approach:
GeneralSettingsPaneltoPrivacyAndSecuritySettingsPanel, and slightly refactored it.GeneralSettingsPaneltoPrivacyAndSecurityPanel, and refactored slightly.Testing strategy:
Tried changing log levels and ensured that the changes were reflected in the log output and in the GUI.
Disabled the source check in
updateCheck, and tried checking for an update with usage stats gathering on and off, and checked that the setting was reflected in the URL.Known issues with pull request:
Users may find it difficult to adjust to the change in location
NVDA's output when tabbing to the "Logging level" control is slightly misleading, as no indication is given that you are out of the "Screen curtain" grouping.
Code Review Checklist: