Skip to content

Fix error when trying to read documents with malformed URL in links#19289

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
nvdaes:fixUrl
Nov 28, 2025
Merged

Fix error when trying to read documents with malformed URL in links#19289
seanbudd merged 2 commits into
nvaccess:masterfrom
nvdaes:fixUrl

Conversation

@nvdaes

@nvdaes nvdaes commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #19125

Summary of the issue:

In Chromium browsers, when the cursor reaches a link with a malformed URL, NVDA cannot read the document.

Description of user facing changes:

Fixed regression: It Will be posible to read documents in Chromium browsers, even if the contain links with a malformed URL.

Description of developer facing changes:

None

Description of development approach:

In the isSamePageURL function of urlUtils, if a ValueError exception is produced when parsing an URL, make the function to return False.

Testing strategy:

Tested locally with Chrom and Edge.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes nvdaes requested a review from a team as a code owner November 27, 2025 05:27
@nvdaes nvdaes requested a review from seanbudd November 27, 2025 05:27
@nvdaes nvdaes marked this pull request as draft November 27, 2025 05:29
@nvdaes nvdaes marked this pull request as ready for review November 27, 2025 06:07
Comment thread source/utils/urlUtils.py

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes

@seanbudd seanbudd merged commit bc2647d into nvaccess:master Nov 28, 2025
39 of 41 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception in isSamePageURL when parsing malformed url

3 participants