Skip to content

fix crowdin sync to beta by running pyright locally#19252

Merged
seanbudd merged 4 commits into
masterfrom
fixCrowdinPyrightLocal
Nov 25, 2025
Merged

fix crowdin sync to beta by running pyright locally#19252
seanbudd merged 4 commits into
masterfrom
fixCrowdinPyrightLocal

Conversation

@seanbudd

@seanbudd seanbudd commented Nov 21, 2025

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

Fetching translations from Crowdin is failing because pre-commit is failing to install on the github actions image.
This is because pyright is failing to install.
We rely on pre-commit to ensure translated files don't introduce regressions.
https://github.com/nvaccess/nvda/actions/runs/19559152241

Description of user facing changes:

none

Description of developer facing changes:

run pyright with uv directly when using pre-commit. This might result in slightly different output to the official hook.

This has the following benefits:

  • we don't need to manually sync versions
  • it matches closer to what we run in GitHub CI (ci/scripts/tests/typeCheck.ps1), as pre-commit CI doesn't support pyright anyway

Description of development approach:

See above

Testing strategy:

We need to test this by getting this on beta's pre-commit yml file

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copilot AI review requested due to automatic review settings November 21, 2025 06:13
@seanbudd seanbudd requested a review from a team as a code owner November 21, 2025 06:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Crowdin translation sync process by replacing the pyright pre-commit hook that relies on the pyright-python repository (which is failing to install on GitHub Actions) with a local hook that runs pyright directly using uv.

Key Changes:

  • Remove the external pyright-python hook that was causing installation failures
  • Add a new local hook that runs pyright using uv run pyright directly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .pre-commit-config.yaml
seanbudd and others added 2 commits November 21, 2025 17:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Nov 25, 2025
Comment thread .pre-commit-config.yaml Outdated
@SaschaCowley SaschaCowley enabled auto-merge (squash) November 25, 2025 05:24
@seanbudd seanbudd disabled auto-merge November 25, 2025 05:45
@seanbudd seanbudd merged commit 282a5cd into master Nov 25, 2025
39 of 41 checks passed
@seanbudd seanbudd deleted the fixCrowdinPyrightLocal branch November 25, 2025 05:46
@github-actions github-actions Bot added this to the 2026.1 milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants