fix crowdin sync to beta by running pyright locally#19252
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Crowdin translation sync process by replacing the pyright pre-commit hook that relies on the pyright-python repository (which is failing to install on GitHub Actions) with a local hook that runs pyright directly using uv.
Key Changes:
- Remove the external
pyright-pythonhook that was causing installation failures - Add a new local hook that runs pyright using
uv run pyrightdirectly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SaschaCowley
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Fetching translations from Crowdin is failing because pre-commit is failing to install on the github actions image.
This is because pyright is failing to install.
We rely on pre-commit to ensure translated files don't introduce regressions.
https://github.com/nvaccess/nvda/actions/runs/19559152241
Description of user facing changes:
none
Description of developer facing changes:
run pyright with uv directly when using pre-commit. This might result in slightly different output to the official hook.
This has the following benefits:
Description of development approach:
See above
Testing strategy:
We need to test this by getting this on beta's pre-commit yml file
Known issues with pull request:
None
Code Review Checklist: