Set the default MathCAT Braille code to AsciiMATH#19232
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default MathCAT Braille code from "Nemeth" to "ASCIIMath" to provide a more universally accessible default for math presentation in braille. ASCIIMath uses the punctuation set from the user's existing output table, making it more language-agnostic and approachable for users who haven't learned specialized mathematics codes. Nemeth, UEB, and other specialized codes remain available as user-selectable options.
Key Changes
- Updated default brailleCode configuration value from "Nemeth" to "ASCIIMath"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
CC @RyanMcCleary, @seanbudd. |
|
@codeofdusk since we know CMU is uncontroversial, can we please use it as default for Spanish? If we build the infrastructure now, it means we can slowly add new defaults as appropriate for different languages. Can we change the default option to I would also encourage emailing the translators email list to get some feedback on other logical defaults |
|
Vietnam, Finnish and Swedish options also exist for sensible defaults |
@seanbudd I'll open an issue (I'd much rather do this in a follow-up) and might not get to it before 2026.1. |
|
@codeofdusk I'm not happy with accepting this PR as-is. If we are going to fix it, let's fix it right |
|
I would also suggest UEB as the default for English rather than ASCIIMath |
|
Thanks @codeofdusk for opening #19233, after discussing internally, we are closing this PR over a proper fix inline with that issue |
Link to issue number:
Split from #19227.
Summary of the issue:
"Nemeth" is unsuitable as a default Braille output code, because:
Description of how this pull request fixes the issue:
This PR changes the default MathCAT Braille code to ASCIIMath.
ASCIIMath uses the punctuation set selected by the user’s existing output table. This has several advantages:
Nemeth, UEB, and other specialized codes remain available as options, and will likely be selected by many users, but which specialized code each user selects will depend highly on their background and preferences.
Testing strategy:
Tested that output appears as expected.
Known issues with pull request:
We could, for some languages, possibly set a smarter default (for instance, CMU is uncontroversial in the Spanish blind community), but that could be done (or not done) at a future time. ASCIIMath is never completely wrong, even if it is not always the optimal choice.
Code Review Checklist: