Allow the mathematics settings panel to load for NVDA languages without defined speech styles#19231
Merged
seanbudd merged 1 commit intoNov 18, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the mathematics settings panel fails to load for NVDA languages that don't have defined speech styles (such as Dutch). The fix relocates the ZIP file path calculation outside the try block and improves error handling.
- Moves
zipFilePathcalculation before the try block to ensure it's defined for error logging - Adds proper context manager (
withstatement) for ZipFile handling - Fixes error message to reference the correct variable (
zipFilePathinstead ofzipFile)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ut defined speech styles
59dd362 to
3b70823
Compare
seanbudd
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Split from #19227.
Summary of the issue:
On languages without defined speech styles, such as
nl, the mathematics settings panel does not load.Description of how this pull request fixes the issue:
Relocate ZIP file path calculation logic.
Testing strategy:
Verified that the mathematics settings panel opens when the nVDA language and voice are set to Dutch.
Known issues with pull request:
None known
Code Review Checklist: