Load MathCAT relative to the app directory#19230
Merged
Merged
Conversation
Contributor
Author
|
CC @RyanMcCleary, @seanbudd. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the MathCAT directory resolution on source copies by changing from using sys.prefix to globalVars.appDir, with appropriate adjustments for source vs. installed copies.
- Changes the base directory calculation in
mathCATDirto useglobalVars.appDirinstead ofsys.prefix - Adds conditional logic to handle source copies (using parent directory) and installed copies (using app directory directly)
- Adds a docstring documenting the property's purpose
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4f36d9b to
2d67d29
Compare
seanbudd
approved these changes
Nov 18, 2025
Member
|
Thanks @codeofdusk |
Member
|
pre-commit.ci run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Split from #19227.
Summary of the issue:
MathCAT is loaded from
sys.prefix, which does not reliably point to the MathCAT directory on source copies.Description of how this pull request fixes the issue:
The MathCAT path is calculated relative to
globalVars.appDir.Testing strategy:
Verified that MathCAT is usable on source copies.
Known issues with pull request:
None known
Code Review Checklist: