Revert "Fix off by one text length in EditTextInfo (#18767)"#19215
Closed
nvdaes wants to merge 1 commit into
Closed
Revert "Fix off by one text length in EditTextInfo (#18767)"#19215nvdaes wants to merge 1 commit into
nvdaes wants to merge 1 commit into
Conversation
This reverts commit a514710.
Collaborator
Author
|
cc: @LeonarddeR |
Collaborator
Collaborator
Author
|
@SaschaCowley , can we close this? |
Member
|
I think we can close this if #19152 gets merged safely, otherwise we can use this as an alternative |
Member
|
I think what was requested in #19203 (comment) was a single PR reverting all related changes |
Member
|
Closing in favour of #19204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a514710.
name: Revert PR
about: Revert an existing pull request
Reverts PR
Reverts #18767
Issues fixed
This doesn't fix issues, but we are reverting several pull request to let NVDA in a clean state to merge #19204 and fix #19152.
Issues reopened
Reopens: None.
Reason for revert
When reverting #18348, test are failing, and we need to make test pass to merge other PRs.
Can this PR be reimplemented? If so, what is required for the next attempt
Perhaps introducing changes in NVDAObjects/window/edit.py, if needed.