Do not mention Notes in Doc formatting settings#19212
Merged
Merged
Conversation
Contributor
Author
|
Cc @Adriani90 since you were the author of #11311. |
SaschaCowley
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #11311
Summary of the issue:
In #11311, it was taken into account that older Excel comments were known as "notes" in newer interfaces, so NVDA's GUI and documentation has been updatedt to be consistent with newer versions.
The "Comments" checkbox in the Document formatting settings panel has been updated to "Notes and comments" as part of this work.
However, this checkbox does not control Excel's comments/notes reporting; it only controls whether comments in text, e.g. in Word, are reported.
Description of user facing changes:
This checkbox has been renamed back to "Comments"
Description of developer facing changes:
N/A
Description of development approach:
N/A
Testing strategy:
Manual check
Known issues with pull request:
One could argue that this checkbox should instead remain "Notes and comments" and should control Excel's Notes or comments.
That's not my approach. And allowing to control "has notes" cell's property while "has formula" cannot be controlled would not be consistent.
Code Review Checklist: