Skip to content

Do not mention Notes in Doc formatting settings#19212

Merged
SaschaCowley merged 1 commit into
nvaccess:masterfrom
CyrilleB79:docFormatting
Nov 14, 2025
Merged

Do not mention Notes in Doc formatting settings#19212
SaschaCowley merged 1 commit into
nvaccess:masterfrom
CyrilleB79:docFormatting

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of #11311

Summary of the issue:

In #11311, it was taken into account that older Excel comments were known as "notes" in newer interfaces, so NVDA's GUI and documentation has been updatedt to be consistent with newer versions.

The "Comments" checkbox in the Document formatting settings panel has been updated to "Notes and comments" as part of this work.

However, this checkbox does not control Excel's comments/notes reporting; it only controls whether comments in text, e.g. in Word, are reported.

Description of user facing changes:

This checkbox has been renamed back to "Comments"

Description of developer facing changes:

N/A

Description of development approach:

N/A

Testing strategy:

Manual check

Known issues with pull request:

One could argue that this checkbox should instead remain "Notes and comments" and should control Excel's Notes or comments.

That's not my approach. And allowing to control "has notes" cell's property while "has formula" cannot be controlled would not be consistent.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Cc @Adriani90 since you were the author of #11311.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review November 13, 2025 20:11
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner November 13, 2025 20:11
@CyrilleB79 CyrilleB79 requested a review from seanbudd November 13, 2025 20:11
@SaschaCowley SaschaCowley merged commit 75cb9eb into nvaccess:master Nov 14, 2025
29 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Nov 14, 2025
@CyrilleB79 CyrilleB79 deleted the docFormatting branch December 9, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants