Fix checkPot for plural#19158
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes issue found while working on #19059
Summary of the issue:
In #19059, commit 9595711, an error is raised during check Pot:
The test should pass or fail but no error should be raised.
The error occurs if a
msgidcommand containing a multi-line string is followed by amsgid_pluralcommand. This had probably never happened before the string introduced in #19059.Description of user facing changes:
The Python script to check Pot does not raise an error before completing.
Description of developer facing changes:
N/A
Description of development approach:
Take into account the presence of
msgid_pluraltoken. Taken into account that a multi-line string in themsgidcommand can end:msgstrcommandmsgid_pluralcommandTesting strategy:
Tested in #19059
Known issues with pull request:
None
Code Review Checklist: