Skip to content

In Outlook Classic, when navigating messages, ensure that wrong info is not displayed in braille#19109

Merged
SaschaCowley merged 9 commits into
nvaccess:masterfrom
nvdaes:outlook
Oct 31, 2025
Merged

In Outlook Classic, when navigating messages, ensure that wrong info is not displayed in braille#19109
SaschaCowley merged 9 commits into
nvaccess:masterfrom
nvdaes:outlook

Conversation

@nvdaes

@nvdaes nvdaes commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Fix unexpected changes for navigator object and wrong updates in braille when navigating messages in Outlook Classic
  • Update changelog

Link to issue number:

Fixes #18993

Summary of the issue:

When navigating the list of messages in Outlook Classic, the navigator object is moved from the focus, showing unexpected information in braille.

Description of user facing changes:

The list of messages can be navigated in Outlook Classic, without receiving unexpected information in braille.

Description of developer facing changes:

None.

Description of development approach:

In the ContactEditField class of the Outlook app module, call to api.setNavigatorObject for the event_valueChange, has been modified setting isFocus to True

Testing strategy:

  • Navigate the list of messages and chek that unexpected information is not presented in braille.
  • Compose messages using fields like To or CC, and check that side effects are not produced.

Known issues with pull request:

The navigator object is still moved, so that the reported navigator object doesn't match the reported focus.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes nvdaes changed the title outlook When navigating messages, avoid moving the navigator object, fixing a bug where unexpected information was displayed in braille Oct 15, 2025
@nvdaes nvdaes changed the title When navigating messages, avoid moving the navigator object, fixing a bug where unexpected information was displayed in braille In Outlook Classic, when navigating messages, avoid moving the navigator object, fixing a bug where unexpected information was displayed in braille Oct 15, 2025
@nvdaes nvdaes marked this pull request as ready for review October 15, 2025 19:24
@nvdaes nvdaes requested a review from a team as a code owner October 15, 2025 19:24
@nvdaes nvdaes requested a review from SaschaCowley October 15, 2025 19:24
@SaschaCowley

SaschaCowley commented Oct 17, 2025

Copy link
Copy Markdown
Member

@Nerlant could you please test this PR and report whether it breaks #18484?

@Nerlant

Nerlant commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

@Nerlant could you please test this PR and report whether it breaks #18484?

It is breaking the reset of the navigator object back to the recipient "To" edit field when the auto-complete list is closed.
Here is an image showing the result of the navigator object not being set correctly:
image

@nvdaes

nvdaes commented Oct 24, 2025

Copy link
Copy Markdown
Collaborator Author

@Nerlant , thanks for testing.
Can you please test these latest changes?

@Nerlant

Nerlant commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

@Nerlant , thanks for testing. Can you please test these latest changes?

I have tested your code. I had to change the api.setNavigatorObject(isFocus=True) to api.setNavigatorObject(self, isFocus=True) for it to run. When also adding the api.setNavigatorObject(self, isFocus=True) to the event_valueChange handler, it is working correctly. Without the change in the event_valueChange handler, the navigation object is not correctly set back to the edit field when the auto-complete list is closed by choosing an entry with enter.

@nvdaes

nvdaes commented Oct 24, 2025

Copy link
Copy Markdown
Collaborator Author

@Nerlant

I had to change the api.setNavigatorObject(isFocus=True) to api.setNavigatorObject(self, isFocus=True)

Oh, sorry. I made a mistake about this.

If you can confirm that all is fixed now, I'll mark this PR as ready for review.
Thanks so much.

@nvdaes nvdaes changed the title In Outlook Classic, when navigating messages, avoid moving the navigator object, fixing a bug where unexpected information was displayed in braille In Outlook Classic, when navigating messages, ensure that wrong info is not displayed in braille Oct 24, 2025
@Nerlant

Nerlant commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

@Nerlant

I had to change the api.setNavigatorObject(isFocus=True) to api.setNavigatorObject(self, isFocus=True)

Oh, sorry. I made a mistake about this.

If you can confirm that all is fixed now, I'll mark this PR as ready for review. Thanks so much.

Yes, the Highlighter behaves as expected now.

@nvdaes

nvdaes commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks so much @Nerlant .
@SaschaCowley , this has been testing. I think that this is ready for review.

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 28, 2025
SaschaCowley
SaschaCowley approved these changes Oct 31, 2025
View reviewed changes

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nvdaes

@SaschaCowley SaschaCowley enabled auto-merge (squash) October 31, 2025 01:23
@SaschaCowley SaschaCowley merged commit a47b87a into nvaccess:master Oct 31, 2025
29 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

Assignees

No one assigned

Labels

blocked/needs-testing conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2026.1

Development

Successfully merging this pull request may close these issues.

Outlook message list first shows the message info and then the to or cc field on a braille display

4 participants

@nvdaes @SaschaCowley @Nerlant @seanbudd