Skip to content

Fix xliff regeneration#19092

Merged
michaelDCurran merged 11 commits into
betafrom
regenXliffFix
Oct 13, 2025
Merged

Fix xliff regeneration#19092
michaelDCurran merged 11 commits into
betafrom
regenXliffFix

Conversation

@michaelDCurran

@michaelDCurran michaelDCurran commented Oct 13, 2025

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #19023
Replaces pr #19054

Summary of the issue:

The GitHub action that regenerates updated xliff files for translation, from English user documentation is currently broken, as the ssh credentials uses an out-of-date key.

Description of user facing changes:

Description of developer facing changes:

Description of development approach:

The GitHub action now uses a GitHub Personal Access Token (PAT) that has permission to push to the repository, and will still trigger future actions.

Testing strategy:

  • Run and ensure it successfully pushes to the pr branch, by temporarily listing the pr branch for the action.
  • Once merged to beta, ensure the action correctly runs.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copilot AI review requested due to automatic review settings October 13, 2025 05:31
@michaelDCurran michaelDCurran requested a review from a team as a code owner October 13, 2025 05:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the broken GitHub Actions workflow for regenerating xliff translation files by replacing SSH-based authentication with a GitHub Personal Access Token (PAT). The workflow was failing due to outdated SSH credentials and now uses a more secure and maintainable authentication method.

  • Replaces SSH key authentication with GitHub PAT for repository access
  • Updates the checkout action to use a newer version
  • Temporarily adds a test branch to validate the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/regenerate_english_userDocs_translation_source.yml Outdated
@michaelDCurran michaelDCurran marked this pull request as draft October 13, 2025 05:32
@michaelDCurran michaelDCurran marked this pull request as ready for review October 13, 2025 06:04
@michaelDCurran michaelDCurran enabled auto-merge (squash) October 13, 2025 07:58
@michaelDCurran michaelDCurran merged commit ed7b72f into beta Oct 13, 2025
29 checks passed
@michaelDCurran michaelDCurran deleted the regenXliffFix branch October 13, 2025 08:31
@github-actions github-actions Bot added this to the 2026.1 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants