Remote Access: Don't warn about ping messages#19079
Merged
Merged
Conversation
seanbudd
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18837
Summary of the issue:
Remote Access logs a warning when i receives a message with type
ping:Description of user facing changes:
None
Description of developer facing changes:
No-longer log when
pingmessages are received.Description of development approach:
Return early from
_remoteClient.transport.TCPTransport.parseif a message is received with type_remoteClient.protocol.RemoteMessageType.PING.Testing strategy:
Known issues with pull request:
None
Code Review Checklist: