Fix 64-bit uninstaller#19067
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the 64-bit uninstaller for NVDA by ensuring the installer reads from the correct registry view. The issue was that the uninstaller couldn't locate the installation directory because it was reading from the 32-bit registry view instead of the 64-bit view where the installation path is stored.
Key changes:
- Added
SetRegView 64instruction to force reading from 64-bit registry view before retrieving installation directory
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19029
Summary of the issue:
The uninstaller for 64-bit builds of NVDA doesn't work.
Description of user facing changes:
The uninstaller works again.
Description of developer facing changes:
None.
Description of development approach:
Tell NSIS that the NVDA install path should be retrieved from a 64-bit view of the registry.
Testing strategy:
Build a launcher. Install it in Windows Sandbox. Uninstall it.
Known issues with pull request:
None.
Code Review Checklist: