Add csrss app module#18975
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Creates a new csrss app module to prevent debug warnings by assuming the csrss.exe process is always alive, addressing permission issues when NVDA attempts to query the process status.
- Adds a csrss app module that overrides the
isAliveproperty to always returnTrue - Prevents continuous debug warnings about inability to get process handle for csrss.exe
- Leverages the fact that csrss.exe is an essential Windows GUI process that is always running
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18859
Related to #18870
Summary of the issue:
Since winBindings and #18833, NVDA spits continuous debug warnings about the inability to get a process handle for csrss.exe
Description of user facing changes:
No errors.
Description of developer facing changes:
None
Description of development approach:
Create a csrss appModule that always assumes csrss.exe to be alive.
Testing strategy:
Ensured that no continuous debug warnings are emitted
Known issues with pull request:
None
Code Review Checklist: