Skip to content

Fix bug when updating add-ons automatically#18971

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
nvdaes:fixUpdateAddons
Sep 23, 2025
Merged

Fix bug when updating add-ons automatically#18971
seanbudd merged 4 commits into
nvaccess:masterfrom
nvdaes:fixUpdateAddons

Conversation

@nvdaes

@nvdaes nvdaes commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator
  • Fix bug when updating add-ons automatically
  • Update changelog

Link to issue number:

Fixes #18965

Summary of the issue:

When NVDA is configured to update add-ons automatically without provide notifications, add-ons aren't updated and an error is produced.

Description of user facing changes:

NVDA can be configured to update add-ons automatically, and this should work as expected.

Description of developer facing changes:

None.

Description of development approach:

Use wx.CallAfter to present a message informing that add-ons are been updated, in the _checkForUpdatableAddonsmethod of the UpdatableAddonsDialog class, just after the condition to check that add-ons should be updated automatically, ensuring that this can be run in the main thread.

Additionally, an error has been discovered and fixed in addonHandler, when installing an add-on which shows a message before installation.

Testing strategy:

Tested locally with clipContentsDesigner (which asks a question before installation) and resourceMonitor.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes nvdaes changed the title Fix bug when update add-ons automatically Fix bug when updating add-ons automatically Sep 23, 2025
@nvdaes nvdaes marked this pull request as ready for review September 23, 2025 04:15
@nvdaes nvdaes requested a review from a team as a code owner September 23, 2025 04:15
@nvdaes nvdaes requested a review from seanbudd September 23, 2025 04:15
Comment thread user_docs/en/changes.md Outdated

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes

@seanbudd seanbudd merged commit f294547 into nvaccess:master Sep 23, 2025
5 of 6 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in option to update add-ons automatically

2 participants