Fix bug when updating add-ons automatically#18971
Merged
Merged
Conversation
seanbudd
reviewed
Sep 23, 2025
seanbudd
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18965
Summary of the issue:
When NVDA is configured to update add-ons automatically without provide notifications, add-ons aren't updated and an error is produced.
Description of user facing changes:
NVDA can be configured to update add-ons automatically, and this should work as expected.
Description of developer facing changes:
None.
Description of development approach:
Use
wx.CallAfterto present a message informing that add-ons are been updated, in the_checkForUpdatableAddonsmethod of theUpdatableAddonsDialogclass, just after the condition to check that add-ons should be updated automatically, ensuring that this can be run in the main thread.Additionally, an error has been discovered and fixed in addonHandler, when installing an add-on which shows a message before installation.
Testing strategy:
Tested locally with clipContentsDesigner (which asks a question before installation) and resourceMonitor.
Known issues with pull request:
None.
Code Review Checklist: