Skip to content

automatically load image descriptions after successfully download #18945

Merged
seanbudd merged 3 commits into
nvaccess:try-64bitfrom
tianzeshi-study:fix-load-model-after-download
Sep 19, 2025
Merged

automatically load image descriptions after successfully download #18945
seanbudd merged 3 commits into
nvaccess:try-64bitfrom
tianzeshi-study:fix-load-model-after-download

Conversation

@tianzeshi-study

@tianzeshi-study tianzeshi-study commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

Summary of the issue:

Fixed an issue where image descriptions would download successfully but not automatically load enabled

Description of user facing changes:

Image descriptions will be automatically loaded after successful download

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@tianzeshi-study tianzeshi-study requested a review from a team as a code owner September 18, 2025 10:28
@tianzeshi-study tianzeshi-study requested review from SaschaCowley and removed request for a team September 18, 2025 10:28
@tianzeshi-study tianzeshi-study changed the title Fixed an issue where image descriptions would download successfully b… automatically load image descriptions after successfully download Sep 18, 2025
pass
if dialog.ShowModal() == ReturnCode.OK:
# load image desc after successful download
import _localCaptioner

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this import to the top at module level

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanbudd seanbudd merged commit 1b360d5 into nvaccess:try-64bit Sep 19, 2025
12 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants