Add support for IE and Edge wxWebView controls#18877
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for NVDA to properly handle focus in wxWebView controls that use either Internet Explorer or Edge WebView2 backends. The fix ensures that browse mode is correctly activated in these web view controls.
Key changes:
- Adds specific focus handling for IE-based wxWebView controls by finding and focusing the inner Internet Explorer_Server window
- Implements focus handling for Edge WebView2 controls by waiting for the Chrome_RenderWidgetHostHWND window creation and refocusing
- Integrates the new wxWebView support into the IAccessible object system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| user_docs/en/changes.md | Adds changelog entry documenting the fix for wxWebView controls |
| source/NVDAObjects/IAccessible/wx.py | New module implementing WxWebView class with backend-specific focus handling |
| source/NVDAObjects/IAccessible/init.py | Integrates wx objects into the IAccessible overlay system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LeonarddeR
commented
Sep 5, 2025
seanbudd
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17273
Summary of the issue:
NVDA has focus issues in WX Web View controls.
Description of user facing changes:
WX Web View controls in applications will no enter browse mode correctly.
Description of developer facing changes:
None
Description of development approach:
There are actually two approaches, one for every known supported backend on Windows:
Testing strategy:
Test test script from #17273. Ensure to test the IE and Edge backends.
Known issues with pull request:
Edge Web View 2 sometimes loads with UIA browse mode, then quickly switches back to IA2 when pressing tab. I don't think this issue is related to the current fix, though.
Code Review Checklist: