Skip to content

Remove unsupported targetArchitectures from builds#18798

Merged
SaschaCowley merged 1 commit intomasterfrom
removeDeadCode
Sep 2, 2025
Merged

Remove unsupported targetArchitectures from builds#18798
SaschaCowley merged 1 commit intomasterfrom
removeDeadCode

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented Aug 25, 2025 •
edited
Loading

Link to issue number:

Related to #18207

Summary of the issue:

There is unused code as nvdaHelper/sconscript instead we use nvdaHelper/archBuild_sconscript

Description of user facing changes:

none

Description of developer facing changes:

none

Description of development approach:

remove dead legacy code for potentially handling 64bit builds.

Testing strategy:

CI/CD

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copilot AI review requested due to automatic review settings August 25, 2025 08:20
@seanbudd seanbudd requested a review from a team as a code owner August 25, 2025 08:20
@seanbudd seanbudd requested a review from SaschaCowley August 25, 2025 08:20
Copilot AI reviewed Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Aug 28, 2025
@SaschaCowley SaschaCowley merged commit 523e2a4 into master Sep 2, 2025
27 checks passed
@SaschaCowley SaschaCowley deleted the removeDeadCode branch September 2, 2025 04:50
@github-actions github-actions bot added this to the 2026.1 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@SaschaCowley SaschaCowley SaschaCowley approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2026.1

Development

Successfully merging this pull request may close these issues.

3 participants

@seanbudd @SaschaCowley