Conversation
4a0b38b to
46e7544
Compare
|
I don't understand why this fails. It looks like there's an oddity with the cache. |
|
Never mind, let's remove 2019. it is no longer supported. See actions/runner-images#12045 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Windows Server 2022 as a supported runner for GitHub Actions workflows to expand system test coverage. The change enables NVDA testing on an additional Windows environment while addressing compatibility issues.
Key changes:
- Adds Windows Server 2022 to the supported runners matrix
- Updates GitHub Actions checkout action to v5
- Excludes symbol pronunciation tests on Windows 2022 due to a known Notepad focus issue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Yeah we were having issues with the cache yesterday - I think related to hitting storage limits. I think they are resolved now? |
seanbudd
left a comment
There was a problem hiding this comment.
Thanks, and neat fix with matrix.exclude
Link to issue number:
Requested in #18708 (comment)
Related to #18684
Summary of the issue:
it was requested to run system tests on Windows Server 2022.
Description of user facing changes:
None
Description of developer facing changes:
NVDA is now systemd tested on Server 2022.
Description of development approach:
Testing strategy:
System tests
Known issues with pull request:
Nothing new apart from the symbols exclusion.
Code Review Checklist:
@coderabbitai summary