Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes cache clearing functionality by switching from using cache keys to cache IDs for more reliable deletion operations. The change improves consistency in the cache cleanup process by using GitHub's cache API with ID-based deletion instead of key-based deletion.
Key changes:
- Modified the
gh cache listcommand to retrieve cache IDs instead of keys - Inlined the jq filter logic directly into the pipeline instead of using an environment variable
- Updated the cache deletion to use IDs for more reliable cleanup operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| shell: bash | ||
| run: | | ||
| gh cache list --order asc --json key,lastAccessedAt | jq --raw-output '${{ env.jqStr }}' | while read -r cache; do | ||
| gh cache list --order asc --json id,lastAccessedAt \ |
There was a problem hiding this comment.
The PR description contains a typo: 'ratehr' should be 'rather'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup of #18751
Uses IDs ratehr than keys to more consistently delete caches