Skip to content

Update Licensecheck to 2025.1#18728

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
bramd:update-licensecheck
Aug 19, 2025
Merged

Update Licensecheck to 2025.1#18728
seanbudd merged 4 commits into
nvaccess:masterfrom
bramd:update-licensecheck

Conversation

@bramd

@bramd bramd commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

N/A

Summary of the issue:

Updated Licensecheck to 2025.1 which recognizes more packages. Removed urllib3 as a license exclusion, since it is recognized correctly.

Description of user facing changes:

None

Description of developer facing changes:

More packages will be recognized by Licensecheck.

Description of development approach:

Updated Licensecheck, commented out exclusions and checked which ones where no longer needed.

Testing strategy:

Ran licensecheck.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@bramd bramd marked this pull request as ready for review August 17, 2025 19:03
@bramd bramd requested a review from a team as a code owner August 17, 2025 19:03
@bramd bramd requested a review from seanbudd August 17, 2025 19:03
Comment thread user_docs/en/changes.md Outdated
@seanbudd seanbudd mentioned this pull request Aug 18, 2025
15 tasks
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Aug 18, 2025
@seanbudd seanbudd merged commit c5e6f38 into nvaccess:master Aug 19, 2025
22 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants