Skip to content

Throw error on no MINI-SEIKA display#18651

Merged
seanbudd merged 1 commit intonvaccess:masterfrom
emmanuel-ferdman:master
Aug 10, 2025
Merged

Throw error on no MINI-SEIKA display#18651
seanbudd merged 1 commit intonvaccess:masterfrom
emmanuel-ferdman:master

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Aug 8, 2025

Link to issue number:

Summary of the issue:

The MINI-SEIKA braille display driver was not properly raising a RuntimeError when no display is found, causing the error condition to be silently ignored instead of properly handled.

Description of user facing changes:

When no MINI-SEIKA display is found, users will now receive proper error feedback instead of the driver silently failing. This improves error reporting and makes it clearer when the display cannot be initialized.

Description of developer facing changes:

Fixed a bug in source/brailleDisplayDrivers/seikantk.py where RuntimeError("No MINI-SEIKA display found") was not being raised properly - added missing raise keyword.

Description of development approach:

Simple one-line fix to add the missing raise keyword before the RuntimeError instantiation. This ensures the exception is actually thrown rather than just creating an unused RuntimeError object.

Testing strategy:

Known issues with pull request:

None identified.

Code Review Checklist:

  • Documentation:
  • Change log entry
  • User Documentation (not applicable for this bug fix)
  • Developer / Technical Documentation (not applicable for this bug fix)
  • Context sensitive help for GUI changes (not applicable)
  • Testing:
  • Unit tests (not applicable for this simple fix)
  • System (end to end) tests (manual testing performed)
  • Manual testing
  • UX of all users considered:
  • Speech (error messages will be properly announced)
  • Braille (affects braille display error handling)
  • Low Vision (not applicable)
  • Different web browsers (not applicable)
  • Localization in other languages / culture than English (error handling improvement)
  • API is compatible with existing add-ons.
  • [] Security precautions taken.

@coderabbitai summary

PR Summary

Small PR - fixes missing raise keyword when throwing an error on no MINI-SEIKA display found.

Changes:

  • source/brailleDisplayDrivers/seikantk.py: Added missing raise keyword before RuntimeError("No MINI-SEIKA display found")

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner August 8, 2025 10:42
@LeonarddeR
Copy link
Copy Markdown
Collaborator

@emmanuel-ferdman Please fill in the complete pull request template.

@seanbudd seanbudd merged commit 45123ac into nvaccess:master Aug 10, 2025
29 of 30 checks passed
@SaschaCowley SaschaCowley added this to the 2025.3 milestone Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants