Throw error on no MINI-SEIKA display#18651
Merged
seanbudd merged 1 commit intonvaccess:masterfrom Aug 10, 2025
emmanuel-ferdman:master
Merged
Throw error on no MINI-SEIKA display#18651seanbudd merged 1 commit intonvaccess:masterfrom emmanuel-ferdman:master
seanbudd merged 1 commit intonvaccess:masterfrom
emmanuel-ferdman:master
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Collaborator
|
@emmanuel-ferdman Please fill in the complete pull request template. |
LeonarddeR
approved these changes
Aug 8, 2025
seanbudd
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue:
The MINI-SEIKA braille display driver was not properly raising a
RuntimeErrorwhen no display is found, causing the error condition to be silently ignored instead of properly handled.Description of user facing changes:
When no MINI-SEIKA display is found, users will now receive proper error feedback instead of the driver silently failing. This improves error reporting and makes it clearer when the display cannot be initialized.
Description of developer facing changes:
Fixed a bug in
source/brailleDisplayDrivers/seikantk.pywhereRuntimeError("No MINI-SEIKA display found")was not being raised properly - added missingraisekeyword.Description of development approach:
Simple one-line fix to add the missing
raisekeyword before the RuntimeError instantiation. This ensures the exception is actually thrown rather than just creating an unused RuntimeError object.Testing strategy:
Known issues with pull request:
None identified.
Code Review Checklist:
@coderabbitai summary
PR Summary
Small PR - fixes missing
raisekeyword when throwing an error on no MINI-SEIKA display found.Changes:
source/brailleDisplayDrivers/seikantk.py: Added missingraisekeyword beforeRuntimeError("No MINI-SEIKA display found")