Remove handling for multiple aria-invalid attributes#18587
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy handling for multiple aria-invalid attributes, as browser support for this non-standard behavior has been discontinued in Chrome and Firefox. The aria-invalid specification never officially supported multiple values, and browsers have dropped their temporary support.
- Removes test case for comma-separated aria-invalid values
- Simplifies aria-invalid processing logic to handle single values only
- Removes excluded_from_build tag from the remaining test
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/system/robot/chromeTests.robot | Removes excluded_from_build tag from aria-invalid test |
| tests/system/robot/chromeTests.py | Removes test case and comments for comma-separated aria-invalid values |
| source/NVDAObjects/IAccessible/init.py | Simplifies aria-invalid processing to use match statement for single values |
SaschaCowley
approved these changes
Jul 31, 2025
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13321
Summary of the issue:
The
aria-invalidspec never supported multiple attributes, however browsers temporarily supported them.This support no longer exists in Chrome or Firefox.
As such tests and handling for multiple aria-invalid attributes should be removed
Description of user facing changes:
None (as browser support was dropped a long time ago)
Description of developer facing changes:
None
Description of development approach:
Remove test case, simplify handling
Testing strategy:
Tested fetching
aria-invalidvia the virtual buffers foraria-invalid="grammar spelling"andaria-invalid="grammar,spelling"to confirm no support in firefox or chrome.Known issues with pull request:
Code Review Checklist:
@coderabbitai summary