Re-enable start from desktop shortcut test#18582
Merged
SaschaCowley merged 3 commits intomasterfrom Jul 30, 2025
Merged
Conversation
39 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables a previously disabled system test that verifies NVDA can start from its desktop shortcut. The test was previously disabled due to reliability issues caused by relying on an already running NVDA instance to send the keyboard shortcut.
- Replaces NVDA's
emulateKeyPresswith direct Windows API calls usingkeybd_event - Updates type annotations to use modern Python syntax (collections.abc imports and union types)
- Removes the exclusion tags that disabled the test from running
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/system/robot/startupShutdownNVDA.robot | Removes test exclusion tags to re-enable the desktop shortcut test |
| tests/system/robot/startupShutdownNVDA.py | Replaces NVDA's keyboard emulation with direct Windows API calls and updates type imports |
| tests/system/libraries/SystemTestSpy/windows.py | Adds sendKeyboardEvent wrapper function and modernizes type annotations |
SaschaCowley
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #14293
Summary of the issue:
The system test 'Starts from desktop shortcut' as part of the 'Basic start and exit tests' defined in startupShutdownNVDA.robot relied on NVDA to be running to send the keyboard shortcut which is intended to start NVDA.
As such it was flakey and disabled.
Description of user facing changes:
none
Description of developer facing changes:
none
Description of development approach:
call keyevents directly rather than through NVDA
Testing strategy:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary