Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the timeout value for the quit from keyboard test to improve test reliability. The test was failing due to insufficient time for NVDA to complete its shutdown process.
- Increases the timeout from 3 to 5 seconds in the
quits_from_keyboard()test function
39 tasks
SaschaCowley
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18561
Summary of the issue:
This test fails due to a timeout. Increasing the timeout might make the test pass more reliably
Description of user facing changes:
none
Description of developer facing changes:
none
Description of development approach:
Increase quit from keyboard timeout
Testing strategy:
test on alpha over time
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary