Fix Remote Access speech when follower has no connected audio render endpoints#18575
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where NVDA Remote Access speech was not working when the controlled computer had no audio output devices enabled. The issue was caused by nvwave.playWaveFile raising an exception when no render endpoints were available.
- Added exception handling in
_remoteClient.cues._playCueto handle failures when playing audio cues - Added debug logging for failed audio playback attempts
- Updated changelog to document the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| user_docs/en/changes.md | Added changelog entry documenting the bug fix |
| source/_remoteClient/cues.py | Added exception handling and logging for audio playback failures |
seanbudd
approved these changes
Jul 29, 2025
# Conflicts: # user_docs/en/changes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18544
Summary of the issue:
When using NVDA Remote Access, if the controlled computer has no audio output devices enabled, speech is not sent to the controlling computer.
Description of user facing changes:
Speech is now sent, even if the controlled computer has no audio output devices enabled.
Description of developer facing changes:
None
Description of development approach:
The issue was caused by
nvwave.playWaveFileraising an exception if no render endpoints were available.To mitigate this,
_remoteClient.cues._playCuenow handles exceptions raised byplayWaveFile.Testing strategy:
Configured the source copy of NVDA to connect as follower automatically on startup. Disabled all audio output devices and launched NVDA from source. Connected on a second device as leader and checked that speech was received.
Known issues with pull request:
The underlying problem has not been resolved. As this involves a change in API behaviour, I will implement it in a separate PR.
Code Review Checklist:
@coderabbitai summary