No longer reset braille tables to auto when changing language#18545
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the automatic reset of braille translation tables when users change NVDA's interface language. Previously, NVDA would force both input and translation braille tables back to "auto" mode whenever the language was changed, which was problematic for users who had manually configured specific braille tables for their needs.
- Removes automatic braille table reset behavior from language change functionality
- Preserves user's manually configured braille table settings when switching languages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| user_docs/en/changes.md | Adds changelog entry documenting the behavioral change |
| source/gui/settingsDialogs.py | Removes the code that automatically resets braille tables to "auto" when language changes |
seanbudd
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18538
Summary of the issue:
NVDA changes braille tables to automatic when changing language. This is undesirable, because when braille tables were ever set manually, we don't want them to be reset without consent.
Description of user facing changes:
Braille tables won't be touched when changing NVDA's language.
Description of developer facing changes:
None
Description of development approach:
Just removal of setters for braille tables when changing language.
Testing strategy:
Tested that the braille tables will no longer be changed when changing language.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary