additional fix to #17984 (MathML attrs in PDF)#18508
Merged
Merged
Conversation
…ce`. It isn't used in speech (although maybe it should trigger a pause if wide), but it is used in some braille notations as a signal that this is a "fill in the blank" space. I also added the elementary math attributes used in MathPlayer. Neither MathCAT nor Access8Math currently support the elementary math notations, but it is on the list of things to implement for MathCAT. Note: potentially this could go into the beta, but I can't get the beta to build on my machine so I can't test the fix there.
See test results for failed build of commit 09ce034112 |
seanbudd
reviewed
Jul 20, 2025
seanbudd
approved these changes
Jul 20, 2025
seanbudd
left a comment
Member
There was a problem hiding this comment.
@SaschaCowley - do you think this should go into 2024.2 beta?
Member
|
@seanbudd I don't think so - it doesn't sound like this fixes a regression or high severity issue |
4 tasks
Contributor
Author
|
The missing attrs fix is pretty obscure and has very little effect. The escaping problem (which is unfortunately slightly tied to this because I messed up my checkout) is less obscure because |
seanbudd
reviewed
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an additional fix to #17984. I missed @width on
mspace. It isn't used in speech (although maybe it should trigger a pause if wide), but it is used in some braille notations as a signal that this is a "fill in the blank" space. For my original fixed, I only looked at what was used in speech for MathCAT.I also added the elementary math attributes used in MathPlayer. Neither MathCAT nor Access8Math currently support the elementary math notations, but it is on the list of things to implement for MathCAT.
Note: potentially this could go into the beta, but I can't get the beta to build on my machine so I can't test the fix there.
Link to issue number:
Closes #17984 (again)
Summary of the issue:
Acrobat's interface doesn't allow code to get all the attributes; they need to be queried individually. I missed an attribute that is relevant for some braille math codes.
Description of user facing changes:
Affects some math braille code output, such as Nemeth code.
Description of developer facing changes:
None.
Description of development approach:
Added some more cases for other math elements
Testing strategy:
Tested$n^p ≡ n \mod {p}$ , with a large space after the $n$ . In MathCAT's Nemeth code output, this results in a blank braille char between $n$ and $\rm{mod}$ .
mspacewith stem-article-2col-se-1.pdf. In section 2.1, there isNote: this is a minor bug in MathCAT because in fact, there shouldn't be a space. However, the very wide space triggers the "fill in the blank" interpretation. This came from LaTeX output; I've asked them to fix this so it isn't interpreted as "fill in the blank". However, the attached PDF serves as a good test that the fix works.
AFAIK, there are currently no PDFs that generate MathML's elementary math notation.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary