Added ability to sort add-ons by last tested version#18506
Conversation
|
@seanbudd , po files contain errors, but I think that this is not related to this PR, so I'll mark this as ready for review. |
|
@nvdaes (author) or @SaschaCowley / @seanbudd (reviewers), what about the visual aspect of the list? Do all the columns fit in the list? It would also be worth having the install date column in the Installed add-ons tab, and have add-ons sorted by install date. This would be very useful for trouble shouting, especially since automatic update is available. I also wonder, at some point, if we should not give the capability to allow the user to choose which columns are displayed, as done in the detailed view of task manager, processes tab. And to be able to sort by any column. All these additional proposals are probably off-topic with respect to this PR, but I mention theme here in case it may impact the choices done in this PR. |
|
Cyrille wrote:
I'm totally blind and I cannot ensure it. But I think so, since, when I created the publication date column in other pull request, sometimes I noted that some columns weren't read, and this was fixed by changin column size. |
|
@nvdaes - Can you also ensure the last tested and minimum API versions are always available in the add-on details panel? right now they are only visible in this installed add-ons tab. |
| ) | ||
| lastTestedVersion = ( | ||
| # Translators: The name of the column that contains the last version of NVDA tested with this add-on. | ||
| pgettext("addonStore", "Last tested NVDA version"), |
There was a problem hiding this comment.
can you also move these after date
|
@CyrilleB79 - the text of the column header is going to be clipped for most resolutions, but the column is fine otherwise. I agree that you should be able to sort by any column - visible or not, and choose what columns to display of all the available information an add-on can have. But this is probably better as a new issue |
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
…to lastTestedVersion
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Link to issue number:
Fixes #18440
Summary of the issue:
Sorting add-ons by last tested version can be helpful to know if an add-on is compatible with an updated version of NVDA, available but not installed yet. In this way, users can decide if they prefer to update NVDA, or wait until a compatible version of the add-on is available.
Description of user facing changes:
In add-on lists of the add-on store, a new column with last tested NVDA version is available, and add-ons can also be sorted by this column.
Description of developer facing changes:
None.
Description of development approach:
In addonStoreGui, viewModels, addonList module, a new field with its corresponding text has been added to create a new column, showing the last tested NVDA version
Testing strategy:
Open the store, switch to various tabs, check that a new column with last tested version is available, and that add-ons can be sorted by this column.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary