Skip to content

Fix SAPI5#18473

Merged
seanbudd merged 2 commits into
nvaccess:betafrom
gexgd0419:sapi5-switch-fixup
Jul 15, 2025
Merged

Fix SAPI5#18473
seanbudd merged 2 commits into
nvaccess:betafrom
gexgd0419:sapi5-switch-fixup

Conversation

@gexgd0419

@gexgd0419 gexgd0419 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixup of #18352.

Summary of the issue:

When WASAPI is turned off, bookmark events are not handled properly.

Description of user facing changes:

Users might not notice that, because although the bookmarks are not handled in time, they are still processed at the end of the utterance.

Description of developer facing changes:

None

Description of development approach:

Code that handles the bookmark events when WASAPI is off is added.

Testing strategy:

Tested manually.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@gexgd0419 gexgd0419 changed the base branch from master to beta July 15, 2025 07:19
@gexgd0419 gexgd0419 marked this pull request as ready for review July 15, 2025 07:26
@gexgd0419 gexgd0419 requested a review from a team as a code owner July 15, 2025 07:26
@gexgd0419 gexgd0419 requested a review from seanbudd July 15, 2025 07:26
@seanbudd seanbudd added this to the 2025.2 milestone Jul 15, 2025
@seanbudd seanbudd merged commit a97baf2 into nvaccess:beta Jul 15, 2025
18 of 20 checks passed
@gexgd0419 gexgd0419 deleted the sapi5-switch-fixup branch August 12, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants