Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the msgfmt.exe binary is bundled with NVDA and updates l10nUtil to dynamically locate it at runtime.
- Add
msgfmt.exeto the installer manifest undermiscDeps/tools - Remove the hardcoded
_MSGFMTpath and compute its location relative to the source file inl10nUtil.py
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/setup.py | Include msgfmt.exe in the distribution manifest |
| source/l10nUtil.py | Replace static _MSGFMT with a runtime path |
Member
Author
|
@wmhn1872265132 - can you please test this build? |
Contributor
This version works fine, thanks for the quick fix |
SaschaCowley
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup of #18270
#18453 (comment)
Summary of the issue:
We use gettext in l10nUtil now, but it wasn't bundled correctly into NVDA
Description of user facing changes:
l10nutil is fixed for translators
Description of development approach:
bundle gettext into nvda distributions
Testing strategy:
test with nvda build
Known issues with pull request:
none
Code Review Checklist:
@coderabbitai summary