Fetch translations from crowdin by seanbudd · Pull Request #18453 · nvaccess/nvda

seanbudd · 2025-07-14T03:31:19Z

Link to issue number:

Part of #17878
Follow up to #18270

Summary of the issue:

Currently, fetching the latest translations from Crowdin is a manual process.

Description of developer facing changes:

A GitHub action to update translations is added. This will run at weekly interval, just before we do a regular release. Translation freezes should be designed to line up with this time. This can be run manually. This will only update tracked translations for existing languages.
A GitHub action to add new languages is added. This is because we have languages which are started in Crowdin, but not ready for sync/release. This will allow us to track new languages.

Description of development approach:

The Crowdin GitHub actions caused problems when running in a windows environment. Using the API directly with l10nUtil seemed cleaner.
To download all translations you must create a project export bundle and download it directly. Adding this to l10nUtil makes it easier for devs to pull all translations from crowdin manually when required.

Testing strategy:

https://github.com/nvaccess/nvda-githubActionsRelease/actions/runs/16262580033/job/45911007067 - example with current failing po file errors preventing a weekly auto-merge
Example of successful update (ignoring errors): https://github.com/nvaccess/nvda-githubActionsRelease/pull/13
Example of adding a new language https://github.com/nvaccess/nvda-githubActionsRelease/pull/14

Known issues with pull request:

None

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

@coderabbitai summary

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…Checker

wmhn1872265132 · 2025-07-14T12:17:53Z

Most of the steps of add-new-language.yml are exactly the same as fetch-crowdin-translations.yml, would it be better to separate it into a composite action? Reduces duplication and facilitates maintenance.

.github/workflows/add-new-language.yml

seanbudd · 2025-07-14T23:24:55Z

Most of the steps of add-new-language.yml are exactly the same as fetch-crowdin-translations.yml, would it be better to separate it into a composite action? Reduces duplication and facilitates maintenance.

I think the workflows are sufficiently different, particularly different message strings, that it makes this not worth it.

wmhn1872265132 · 2025-07-15T05:14:28Z

Please note: After #18270 merge, an error occurs when uploading nvda.po using l10nUtil included in the launcher:

Traceback (most recent call last):
File "l10nUtil.py", line 740, in
File "l10nUtil.py", line 727, in main
File "l10nUtil.py", line 568, in checkPo
File "l10nUtil.py", line 452, in check
File "l10nUtil.py", line 367, in _checkSyntax
File "subprocess.pyc", line 548, in run
File "subprocess.pyc", line 1026, in init
File "subprocess.pyc", line 1538, in _execute_child
FileNotFoundError: [WinError 2] 系统找不到指定的文件。

.github/workflows/fetch-crowdin-translations.yml

Co-authored-by: Noelia Ruiz Martínez <nrm1977@gmail.com>

Copilot

Pull Request Overview

This PR introduces automation for fetching and adding translations from Crowdin by extending l10nUtil.py and adding two GitHub workflows.

Adds an exportTranslations function and CLI command to bundle, download, and extract translations.
Integrates the new command into the main l10n utility.
Adds workflows to regularly update tracked languages and to add new languages on demand.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
source/l10nUtil.py	Added `exportTranslations` function and CLI parser integration.
.github/workflows/fetch-crowdin-translations.yml	Workflow to auto-fetch and commit tracked translations weekly.
.github/workflows/add-new-language.yml	Workflow to manually add and track new languages from Crowdin.

Comments suppressed due to low confidence (1)

source/l10nUtil.py:289

Add unit tests for exportTranslations to cover build initiation, polling logic, download, and extraction of the translation archive, ensuring errors are handled as expected.

def exportTranslations(outputDir: str, language: str | None = None):

source/l10nUtil.py

…val and timeout

source/l10nUtil.py

seanbudd and others added 15 commits June 17, 2025 16:12

Add a pofile syntax checker

83faa90

Pre-commit auto-fix

1340f50

Merge remote-tracking branch 'origin/beta' into addPoFileChecker

d99a1bc

Add GitHub actions step for po file checking

266f846

Pre-commit auto-fix

0766db9

Create draft for fetching translations froms Crowdin

c201843

Update ci/scripts/poChecker.py

6277957

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Pre-commit auto-fix

e661268

Update ci/scripts/poChecker.py

ade76ac

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ci/scripts/poChecker.py

0429955

ensure msgfmt

28c8cc8

fix msgfmt

e07f82a

Apply suggestions from code review

1401e18

Update .github/workflows/testAndPublish.yml

250cde2

Pre-commit auto-fix

b3957dc

seanbudd mentioned this pull request Jul 14, 2025

Retire AppVeyor, ensure GitHub actions has feature parity #17878

Closed

39 tasks

seanbudd and others added 6 commits July 14, 2025 15:16

add checks when translators upload/download strings

9078b24

Pre-commit auto-fix

84a0010

fix up uv usage

7e0582c

Merge remote-tracking branch 'origin/addPoFileChecker' into addPoFile…

c754e31

…Checker

Pre-commit auto-fix

a8a8896

add check to download from crowdin

b07c59d

seanbudd force-pushed the fetchFromCrowdin branch from b6b9911 to b07c59d Compare July 14, 2025 07:59

seanbudd added 7 commits July 14, 2025 18:05

Merge remote-tracking branch 'origin/beta' into fetchFromCrowdin

270bd0e

checkout submodules

e8f0af4

take auth token from env

507c1ae

use bash

1cdfb89

use bash

cebf110

push before pr create

8e11113

fix up failure msg

8002be5

seanbudd added 3 commits July 14, 2025 18:48

fix up precommit check

705a3f2

Improve failure behaviour add lang tracking

a678b16

remove failure comments

6f9c248

seanbudd marked this pull request as ready for review July 14, 2025 09:10

seanbudd requested a review from a team as a code owner July 14, 2025 09:10

seanbudd requested review from SaschaCowley and removed request for a team July 14, 2025 09:10

fix up language

ea660cc

wmhn1872265132 reviewed Jul 14, 2025

View reviewed changes

.github/workflows/add-new-language.yml Show resolved Hide resolved

seanbudd changed the base branch from addPoFileChecker to beta July 15, 2025 02:41

Merge remote-tracking branch 'origin/beta' into fetchFromCrowdin

01b0eae

seanbudd mentioned this pull request Jul 15, 2025

Fix l10n util, bundle gettext #18472

Merged

5 tasks

SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jul 15, 2025

nvdaes reviewed Jul 16, 2025

View reviewed changes

.github/workflows/fetch-crowdin-translations.yml Outdated Show resolved Hide resolved

Update .github/workflows/fetch-crowdin-translations.yml

d546c07

Co-authored-by: Noelia Ruiz Martínez <nrm1977@gmail.com>

seanbudd added this to the 2025.2 milestone Jul 17, 2025

seanbudd requested a review from Copilot July 17, 2025 07:08

Copilot AI reviewed Jul 17, 2025

View reviewed changes

source/l10nUtil.py Outdated Show resolved Hide resolved

source/l10nUtil.py Outdated Show resolved Hide resolved

seanbudd added 2 commits July 17, 2025 17:29

Refactor translation export process to use configurable polling inter…

5ea7698

…val and timeout

Merge remote-tracking branch 'origin/beta' into fetchFromCrowdin

d527240

michaelDCurran requested changes Jul 18, 2025

View reviewed changes

source/l10nUtil.py Outdated Show resolved Hide resolved

Update source/l10nUtil.py

b5a4659

seanbudd requested a review from michaelDCurran July 18, 2025 03:46

michaelDCurran approved these changes Jul 18, 2025

View reviewed changes

source/l10nUtil.py Outdated Show resolved Hide resolved

Update source/l10nUtil.py

546acf9

seanbudd merged commit 6bea5b1 into beta Jul 18, 2025
4 of 6 checks passed

seanbudd deleted the fetchFromCrowdin branch July 18, 2025 04:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fetch translations from crowdin#18453

Fetch translations from crowdin#18453
seanbudd merged 38 commits intobetafrom
fetchFromCrowdin

seanbudd commented Jul 14, 2025 •

edited

Loading

Uh oh!

wmhn1872265132 commented Jul 14, 2025

Uh oh!

Uh oh!

seanbudd commented Jul 14, 2025

Uh oh!

wmhn1872265132 commented Jul 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

seanbudd commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of developer facing changes:

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

wmhn1872265132 commented Jul 14, 2025

Uh oh!

Uh oh!

seanbudd commented Jul 14, 2025

Uh oh!

wmhn1872265132 commented Jul 15, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

seanbudd commented Jul 14, 2025 •

edited

Loading