winVersion: report Windows build revision when winVersion.getWinVer is called and at startup#18306
Merged
Merged
Conversation
…it to 0 by defualt. Re nvaccess#18266. Windows versions are usually identified as major.minor.build. However, a fourth number, 'revisoin' (UBR: update build revision) is added to identify QFE (quick fix engineering)/cumulative update revision number. This is useful in that developers can determine if an issue experienced by users is resolved in a later cumulative update. Therefore, expose revision number (default: 0) as part of WinVersion class attributes and print it at NVDA startup.
…ry. Re nvaccess#18266. Update build revision (UBR) lives in Windows Registry (HKLM\Software\Microsoft\Windows NT\CurrentVersion, key: UBR, type: dword). At startup, obtain this value and set it as 'revision' argument to winVersion.WinVersion constructor.
seanbudd
reviewed
Jun 23, 2025
Contributor
Author
|
Hi, yes – have tested this code base on Windows 8.1 (VM) via Resource Monitor add-on for years without issues. Thanks.
|
seanbudd
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18266
Summary of the issue:
NVDA does not report Windows build revision at startup.
Description of user facing changes:
NVDA will log Windows build revisoin number (e.g. 10.0.26100.0) at startup.
Description of developer facing changes:
NVDA will report update build revision (UBR) number when winVersion.getWinVer function is called. In addition, "revisoin" was added as an argument to winVersion.WinVersion class constructor (default: 0).
Description of development approach:
Added "revisoin" to winVersion.WinVersion constructor. In winVersion.getWinVer, this value is obtained from Windows Registry and is reported at NVDA startup.
Testing strategy:
Manual: make sure the four part number for a Windows build (e.g. 10.0.26100.4351) is whon in the log viewer at startup and from winVersion.getWinVer function.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary