Windows 11 emoji panel: prevent speech repetition while browsing panel items#18237
Merged
seanbudd merged 5 commits intoJun 11, 2025
Merged
Conversation
…ementation of event_selection routine handle emoji panel item announcement while the panel is focused. Re nvaccess#18236. Suppose a Windows 11 user presses Windows+Peroid (.) to open the emoji panel and presses arorw keys to review emojis. NVDA will announce items twice because: 1. The app module implementation of UIA element selected event will announce panel entris after setting navigator object ot them. 2. In the base NVDA object implementation of event_selection (which the UIA element selected event handler fro mthe base UIA object invokes), selected eoji panel item is announced again because the focused app is indeed modern keyboard. Therefore, let the base UIA object handle panel item announcement on Windows 11 because emoji panel takes system focus. This prevents item repetitions.
seanbudd
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18236
Summary of the issue:
NVDA repeats Windows 11 emoji panel items twice while browsing them.
Description of user facing changes:
NVDA will no longer speak Windows 11 emoji panel items twice.
Description of developer facing changes:
NVDA will call nextHandler() when handling UIA element selected event while focused on the emoji panel.
Description of development approach:
When handling element selected event, call nextHandler() if focused on the emoji panel. This also improves element selected event performance as emoji panel item selection announcement will not involve traversing the event handler to the end.
Testing strategy:
Manual: open Windows 11 emoji panel (Windows+Period) and make sure NVDA is announcing selected item once.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary