Fixed support for paragraph mouse text unit in Java applications.#18232
Merged
Conversation
Contributor
Author
|
CC: @jcsteh |
seanbudd
reviewed
Jun 10, 2025
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Member
|
@mwhapples - do you have any thoughts on this PR given your experience with Java? |
seanbudd
approved these changes
Jun 23, 2025
# Conflicts: # user_docs/en/changes.md
See test results for failed build of commit 2b3e13e7ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18231
Summary of the issue:
Previously, JABTextInfo's _getParagraphOffsets used its own _getLineOffsets to obtain paragraph offsets, which resulted in only the line under the mouse being reported in the paragraph mouse text unit.
Description of user facing changes:
Now report the paragraph under the mouse.
Description of developer facing changes:
JABTextInfo obtains the correct offset for the paragraph.
Description of development approach:
_getStoryTextmethod has been added toJABTextInfoso thatOffsetsTextInfo._getLineOffsetscan work.JABTextInfo._getParagraphOffsetsnow uses the superclass_getLineOffsetsto calculate offsets based on text content.Testing strategy:
This PR only affects cases where the mouse text unit is a paragraph.
Run TextComponentDemo.java to test.
Manual testing:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary