Windows 11 Notepad: reclassify "go to line" edit field as a proper edit field#18216
Merged
seanbudd merged 6 commits intoJun 11, 2025
Merged
Conversation
…it field. Re nvaccess#18208. Somehow, 'go to line' (Contorl+G) edit field is seen as a dialog by NVDA, therefore reclassify the object role (dialog -> editable text). This allows speak typed characters/words setting to be honored, including speaking only in edit controls.
LeonarddeR
reviewed
Jun 4, 2025
Contributor
Author
|
Hi, yep, we should work on removing comments like this from the source code…
|
Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>
…oLineEditField # Conflicts: # user_docs/en/changes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18208
Summary of the issue:
In Windows 11 Notepad, go to line (Control+G) edit field is seen as a UIA dialog, causing speak typed characters/words setting (especially speak only in edit controls) to not be honored.
Description of user facing changes:
NVDA will recognize go to line control as an edit field, allowing speak typed characters/words only in edit controls setting to work.
Description of developer facing changes:
Reclassified "go to line" edit field (UIA Automation Id: LineNumberBox) as an edit field (UIA class name is TextBox yet UIA says this control is a dialog).
Description of development approach:
Testin with Windows 11 Notepad 11.2504.46.0: use event_NVDAObject_init to workaround UIA dialog classification for this control.
Testing strategy:
Manual testing:
Known issues with pull request:
None at the moment, although the UIA Automation Id and other UIA properties can change in future Notepad releaes, or Microsoft may fix this, makin the PR unnecessary.
Code Review Checklist:
@coderabbitai summary