Conversation
39 tasks
seanbudd
commented
Jun 3, 2025
seanbudd
commented
Jun 3, 2025
SaschaCowley
approved these changes
Jun 4, 2025
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #17878
Summary of the issue:
System tests are the slowest part of the GitHub actions build, taking about 20min.
System tests could be split up to speed up the build, run in parallel via a matrix.
Description of user facing changes:
None
Description of developer facing changes:
Description of development approach:
Use a matrix and env variable to set the system test suite up to run test suites simultaneously across runners.
Testing strategy:
This PRs GitHub actions CI/CD results.
Tested a failure using known failing tests: https://github.com/nvaccess/nvda/actions/runs/15410983376.
When this test suite failed, other tests continued on running as intended. i.e. one test failure still allows the rest of the tests to complete for reporting, but doesn't pass the build.
Known issues with pull request:
Ideally we should split up the chrome testing suite into logical subgroups.
We could save about 10min/build splitting it into 4+ groups.
Then we can parallelize more of the chrome tests.
This should be considered in a different issue/PR.
More documentation may be needed in
tests/system/readme.md. Any suggestions on what to add?Code Review Checklist:
@coderabbitai summary