Bugfix for Braille display detection#18115
Conversation
LeonarddeR
left a comment
There was a problem hiding this comment.
Interesting bug and good catch!
LeonarddeR
left a comment
There was a problem hiding this comment.
I was too quick. Could you also update the changelog for this?
I think it might make sense to have this in NVDA 2025.1, but I leave it up to NV Access to decide so.
It's my first pull requqest and I'm not finding any Changelog.md to edit, do you mean the changelog section in the PR? Is there a specific format or is it enough to write a small sentence like "Fixed Braille display detection"? |
|
Could you please edit the file user_docs/en/changes.md and add the changelog entry under bug fixes? |
Ok I have changed the file in the section of NVDA 2025.1 as you suggested, is it ok or should I move the change to 2025.2? |
Quick fix for an error when adding a device to the fallback list due to an incorrect use of sets
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
SaschaCowley
left a comment
There was a problem hiding this comment.
Thanks, @christiancomaschi
|
I have a Focus braille display from Freedom Scientific, connected via USB. The display works with Jaws, but it doesn't work with NVDA. |
|
@sharkboyto I'm pretty sure that issue is not related, please open a new issue for this. |
Link to issue number:
closes #18114
Summary of the issue:
Braille display sometimes failing to be detected
Description of user facing changes
Description of development approach
I read the log file and found that the problem was an incorrect use of sets while populating the fallback drivers list
Testing strategy:
I replaced BdDetect.py with my fixed version in the latest beta portable version, restarted NVDA and now it seems to work and doesn't raise any TypeError
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary