Skip to content

Do not interrupt Remote Access status messages when executing from the NVDA Menu#18070

Merged
SaschaCowley merged 6 commits into
betafrom
remoteMenuMessages
May 9, 2025
Merged

Do not interrupt Remote Access status messages when executing from the NVDA Menu#18070
SaschaCowley merged 6 commits into
betafrom
remoteMenuMessages

Conversation

@SaschaCowley

@SaschaCowley SaschaCowley commented May 8, 2025

Copy link
Copy Markdown
Member

Link to issue number:

Closes #17947
Supersedes #17991

Summary of the issue:

When executing some Remote Access actions via the Remote Access submenu in the NVDA menu, the status is interrupted by the focus changing, making the messages useless.

Description of user facing changes

Remote Access actions performed via the NVDA menu should now correctly report their status.

Description of development approach

  • Add a delayedMessage function to ui, based on the approach taken for focusing open blocking modals in Message Dialog API take 2 #17582.
    • Remove the now duplicated code, and replace it with a call to ui.delayedMessage.
  • In _remoteClient.client.RemoteClient, updated copyLink, pushClipboard, and toggleMute, to use ui.delayedMessage instead of ui.message, as these methods can be envoked directly from the menu.
    • Also moved the success message out of globalCommands.GlobalCommands.script_copyRemoteLink into _remoteClient.client.RemoteClient.copyLink.
  • Updated _remoteClient.cues._playCue to use ui.delayedMessage instead of ui.message, as the "Disconnect" menu item causes a cue to be issued. This means that cues should work even if issued at the same time as a UI change, and should have very little performance impact.

Testing strategy:

  • Performed the above listed commands with and without a Remote Access session in progress.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley requested a review from a team as a code owner May 8, 2025 06:01
@SaschaCowley SaschaCowley requested a review from seanbudd May 8, 2025 06:01
@LeonarddeR

Copy link
Copy Markdown
Collaborator

Great addition! I can think of several other messages that can benefit from this, particularly the configuration saving and resetting action messages that are discarded similarly when executed from the menu.

@SaschaCowley SaschaCowley merged commit 1932ee8 into beta May 9, 2025
5 checks passed
@SaschaCowley SaschaCowley deleted the remoteMenuMessages branch May 9, 2025 06:03
@github-actions github-actions Bot added this to the 2025.2 milestone May 9, 2025
@seanbudd seanbudd modified the milestones: 2025.2, 2025.1 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants