Do not interrupt Remote Access status messages when executing from the NVDA Menu#18070
Merged
Conversation
Collaborator
|
Great addition! I can think of several other messages that can benefit from this, particularly the configuration saving and resetting action messages that are discarded similarly when executed from the menu. |
seanbudd
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17947
Supersedes #17991
Summary of the issue:
When executing some Remote Access actions via the Remote Access submenu in the NVDA menu, the status is interrupted by the focus changing, making the messages useless.
Description of user facing changes
Remote Access actions performed via the NVDA menu should now correctly report their status.
Description of development approach
delayedMessagefunction toui, based on the approach taken for focusing open blocking modals in Message Dialog API take 2 #17582.ui.delayedMessage._remoteClient.client.RemoteClient, updatedcopyLink,pushClipboard, andtoggleMute, to useui.delayedMessageinstead ofui.message, as these methods can be envoked directly from the menu.globalCommands.GlobalCommands.script_copyRemoteLinkinto_remoteClient.client.RemoteClient.copyLink._remoteClient.cues._playCueto useui.delayedMessageinstead ofui.message, as the "Disconnect" menu item causes a cue to be issued. This means that cues should work even if issued at the same time as a UI change, and should have very little performance impact.Testing strategy:
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary