Skip to content

Enable code signing on GH Actions#18034

Merged
seanbudd merged 8 commits intomasterfrom
ghSigning
Jun 25, 2025
Merged

Enable code signing on GH Actions#18034
seanbudd merged 8 commits intomasterfrom
ghSigning

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented May 1, 2025 •
edited
Loading

Link to issue number:

Part of #17878

Summary of the issue:

Code signing is missing from GitHub actions, which needs to be added to have full parity to AppVeyor

Description of user facing changes

None

Description of development approach

Set in api signing token in GitHub secrets, create a signed build if appropriate

Testing strategy:

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 5, 2025
LeonarddeR
LeonarddeR reviewed May 6, 2025
View reviewed changes
@seanbudd seanbudd mentioned this pull request May 7, 2025
Closed
39 tasks
LeonarddeR
LeonarddeR reviewed May 7, 2025
View reviewed changes
@AppVeyorBot
Copy link
Copy Markdown

AppVeyorBot commented May 7, 2025

See test results for failed build of commit f37e780f7a

seanbudd
seanbudd commented Jun 6, 2025
View reviewed changes
@seanbudd seanbudd mentioned this pull request Jun 13, 2025
Merged
9 tasks
@seanbudd seanbudd marked this pull request as ready for review June 13, 2025 05:02
@seanbudd seanbudd requested a review from a team as a code owner June 13, 2025 05:02
@seanbudd seanbudd requested a review from SaschaCowley June 13, 2025 05:02
seanbudd
seanbudd commented Jun 13, 2025
View reviewed changes
SaschaCowley
SaschaCowley reviewed Jun 13, 2025
View reviewed changes
@seanbudd @SaschaCowley
Update sconstruct
9029dd0 
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
seanbudd
seanbudd commented Jun 13, 2025
View reviewed changes
@seanbudd seanbudd added this to the 2025.2 milestone Jun 24, 2025
@seanbudd seanbudd removed the blocked label Jun 25, 2025
seanbudd
seanbudd commented Jun 25, 2025
View reviewed changes
@seanbudd seanbudd requested a review from SaschaCowley June 25, 2025 05:41
@SaschaCowley
Copy link
Copy Markdown
Member

SaschaCowley commented Jun 25, 2025

@seanbudd is signing supposed to be happening on all PRs targeting master/beta/rc? Because it seems like it is at present. I thought it was only supposed to happen on try builds, or commits to master/beta/rc (snapshots)

@seanbudd
Copy link
Copy Markdown
Member Author

seanbudd commented Jun 25, 2025

@SaschaCowley signing will only occur on pushes (github.event_name == 'push'). i.e. pushes to master/beta/rc/try-* or a release tag

@seanbudd
Copy link
Copy Markdown
Member Author

seanbudd commented Jun 25, 2025

additionally, secrets will be empty on any PR not based on nvaccess/nvda

@seanbudd
Copy link
Copy Markdown
Member Author

seanbudd commented Jun 25, 2025

This PR was not signed if you want testing confirmation

@SaschaCowley
Copy link
Copy Markdown
Member

SaschaCowley commented Jun 25, 2025

Aah yep, gotcha. I forgot how the 'push' event works

@seanbudd seanbudd merged commit 76067ca into master Jun 25, 2025
16 of 17 checks passed
@seanbudd seanbudd deleted the ghSigning branch June 25, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

+1 more reviewer

@LeonarddeR LeonarddeR LeonarddeR left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. release/blocking-beta

Projects

None yet

Milestone

2025.2

Development

Successfully merging this pull request may close these issues.

4 participants

@seanbudd @AppVeyorBot @SaschaCowley @LeonarddeR