Skip to content

Add symbols generation to GH Actions#18033

Merged
SaschaCowley merged 6 commits intomasterfrom
ghActions
May 2, 2025
Merged

Add symbols generation to GH Actions#18033
SaschaCowley merged 6 commits intomasterfrom
ghActions

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented May 1, 2025

Link to issue number:

Part of #17878

Summary of the issue:

Symbols generation is missing from GitHub actions, which needs to be added to have full parity to AppVeyor

Description of user facing changes

None

Description of development approach

Copied logic from AppVeyor

Testing strategy:

  • Test symbol artifact is created
  • Test symbols are uploaded to mozilla with a try build

Known issues with pull request:

Symbols upload to mozilla is currently broken

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd marked this pull request as ready for review May 1, 2025 02:50
@seanbudd seanbudd requested a review from a team as a code owner May 1, 2025 02:50
@seanbudd seanbudd requested a review from SaschaCowley May 1, 2025 02:51
# Conflicts:
#	.github/workflows/testAndPublish.yml
@SaschaCowley SaschaCowley merged commit e5b0bf7 into master May 2, 2025
4 of 5 checks passed
@SaschaCowley SaschaCowley deleted the ghActions branch May 2, 2025 05:45
@github-actions github-actions bot added this to the 2025.2 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants